[Feat/#120] 게시물 떠먹기 API 연결 #123

Roel4990 · 2025-01-22T19:20:54Z

Related issue 🛠

closed [FEAT] 게시물 떠먹기 API 연결 #120

Work Description ✏️

게시물 떠먹기 API 연결

Screenshot 📸

To Reviewers 📢

…st-api

…stDto 수정

chattymin

고생하셨슴다~

…st-api # Conflicts: # app/src/main/java/com/spoony/spoony/data/datasource/PostRemoteDataSource.kt # app/src/main/java/com/spoony/spoony/data/datasourceimpl/PostRemoteDataSourceImpl.kt # app/src/main/java/com/spoony/spoony/data/dto/base/BaseResponse.kt # app/src/main/java/com/spoony/spoony/data/repositoryimpl/PostRepositoryImpl.kt # app/src/main/java/com/spoony/spoony/data/service/PostService.kt # app/src/main/java/com/spoony/spoony/presentation/placeDetail/PlaceDetailViewModel.kt

Hyobeen-Park

수고하셨습니다!! 명세서와 맞지 않은 부분이 있는 것 같은데 한번만 확인 부탁드립니다😊

Hyobeen-Park · 2025-01-22T19:34:07Z

app/src/main/java/com/spoony/spoony/domain/repository/PostRepository.kt

@@ -1,11 +1,12 @@
 package com.spoony.spoony.domain.repository

+import com.spoony.spoony.data.dto.base.BaseResponse


P1: 잡았다!!!! Domain 레이어에서는 Data 레이어의 dto를 사용하면 안됩니다!! 이유가 무엇일까요??

data 계층과 domain 계층간의 결합도가 높아져서 입니다! 수정했습니다.

Hyobeen-Park · 2025-01-22T19:36:30Z

app/src/main/java/com/spoony/spoony/presentation/placeDetail/PlaceDetailViewModel.kt

+                        false -> {
+                            // 통신에 성공했지만 떠먹기에 실패했을 경우
                        }


P1: 이 부분이 스푼이 부족해서 떠먹기에 실패한 경우가 맞을까요?? 명세서를 확인해보니 해당 상황에서는 요청이 반려된다고 해서 onSuccess가 아닌 onFailure로 처리해야 할 것 같습니다!! 이 부분 한번만 다시 확인 부탁드릴게요!

수정했습니다!

Hyobeen-Park · 2025-01-22T19:36:51Z

app/src/main/java/com/spoony/spoony/presentation/placeDetail/PlaceDetailViewModel.kt

                        }
                    }
                }
                .onFailure {
-                    // 실패 했을 경우
+                    // 통신에 실패 했을 경우


P1: 통신에 실패했을 경우 로직도 추가해주세요!!

추가했습니다!

angryPodo

고생하셨습니다~

Hyobeen-Park

약간 걸리는 부분이 있어서 코리 남겨두었습니다..!! 한번만 확인 부탁드려요😊

Hyobeen-Park · 2025-01-22T20:47:23Z

app/src/main/java/com/spoony/spoony/presentation/placeDetail/PlaceDetailViewModel.kt

+                            _state.update {
+                                it.copy(
+                                    postEntity = UiState.Success(
+                                        copy(isScooped = false)


P2: 여기에 copy가 왜 또 들어가나요..???? 위에서 copy 해주고 있어서 안쪽에서는 안해도 될 것 같습니다!

수정했습니다!

Hyobeen-Park · 2025-01-22T20:49:54Z

app/src/main/java/com/spoony/spoony/presentation/placeDetail/PlaceDetailViewModel.kt

+                        with(currentPostEntity) {
+                            _state.update {
+                                it.copy(
+                                    postEntity = UiState.Success(


P2: onFailure일 때도 UiState.Success로 넣어주고 있네요!! 제 생각에는 Failure로 해줘야 더 명확하지 않을까 싶습니다 세홍님 생각은 어떠세요?

수정했습니다!

…st-api

postEntity -> postModel 로 분리 후 isScooped, isAddMap, addMapCount state 로 관리

…st-api

Hyobeen-Park

얼렁 수정하자!!!!!

Hyobeen-Park · 2025-01-22T22:05:53Z

app/src/main/java/com/spoony/spoony/presentation/placeDetail/model/PostModel.kt

+import okhttp3.internal.toImmutableList
+
+data class PostModel(
+    val photoUrlList: List<String>,


P1: ImmutableList로 수정해주세요!!

수정했습니다!

Hyobeen-Park · 2025-01-22T22:06:12Z

app/src/main/java/com/spoony/spoony/presentation/placeDetail/model/PostModel.kt

+
+import com.spoony.spoony.domain.entity.CategoryEntity
+import com.spoony.spoony.domain.entity.PostEntity
+import okhttp3.internal.toImmutableList


P1: 임포트 잘못 들어간 것 같아요!! 다시 한번만 확인 부탁드립니다~~

이걸잡다니... 감사합니다!

Hyobeen-Park

어푸푸!!🚀🚀

Roel4990 added 5 commits January 23, 2025 02:40

[FEAT/#120] 게시물 떠먹기 API 연결

638a4be

Merge remote-tracking branch 'origin/develop' into feat/#120-scoop-po…

11bb946

…st-api

[FEAT/#120] BaseResponseDTO -> BaseResponse 로 수정

fc1eeeb

[FEAT/#120] PostService companion object 제거

3a3ff75

[FEAT/#120] useSpoon param 수정 및 PostScoopRequestDTO -> PostScoopReque…

9d83e47

…stDto 수정

Roel4990 added 🧡세홍🧡 🧡세홍🧡 FEAT✨ 새로운 기능 구현 labels Jan 22, 2025

Roel4990 requested review from chattymin, Hyobeen-Park and angryPodo January 22, 2025 19:20

Roel4990 self-assigned this Jan 22, 2025

Roel4990 requested a review from a team as a code owner January 22, 2025 19:20

Roel4990 linked an issue Jan 22, 2025 that may be closed by this pull request

[FEAT] 게시물 떠먹기 API 연결 #120

Closed

1 task

chattymin approved these changes Jan 22, 2025

View reviewed changes

Hyobeen-Park requested changes Jan 22, 2025

View reviewed changes

Roel4990 added 2 commits January 23, 2025 05:09

[FEAT/#120] 코드리뷰 수정사항 수정

b355bfc

[FEAT/#120] 코드리뷰 수정사항 수정

6075332

Roel4990 requested a review from Hyobeen-Park January 22, 2025 20:14

angryPodo approved these changes Jan 22, 2025

View reviewed changes

Hyobeen-Park requested changes Jan 22, 2025

View reviewed changes

Roel4990 added 3 commits January 23, 2025 06:20

Merge remote-tracking branch 'origin/develop' into feat/#120-scoop-po…

4f54f84

…st-api

[FEAT/#120]

bf12e51

postEntity -> postModel 로 분리 후 isScooped, isAddMap, addMapCount state 로 관리

[FEAT/#120] ktLintFormat 처리

37e98aa

Roel4990 requested a review from Hyobeen-Park January 22, 2025 21:46

Roel4990 added 2 commits January 23, 2025 06:52

Merge remote-tracking branch 'origin/develop' into feat/#120-scoop-po…

22acdff

…st-api

Merge remote-tracking branch 'origin/develop' into feat/#120-scoop-po…

372c8ba

…st-api

Hyobeen-Park requested changes Jan 22, 2025

View reviewed changes

Roel4990 added 2 commits January 23, 2025 07:07

[FEAT/#120] 잘못된 toImmutableList 임포트 수정

2463c9c

[FEAT/#120] List -> ImmutableList 로 수정

a392a7b

Roel4990 requested a review from Hyobeen-Park January 22, 2025 22:09

Hyobeen-Park approved these changes Jan 22, 2025

View reviewed changes

Roel4990 merged commit fdd395e into develop Jan 22, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat/#120] 게시물 떠먹기 API 연결 #123

[Feat/#120] 게시물 떠먹기 API 연결 #123

Roel4990 commented Jan 22, 2025

chattymin left a comment

Hyobeen-Park left a comment

Hyobeen-Park Jan 22, 2025

Roel4990 Jan 22, 2025

Hyobeen-Park Jan 22, 2025

Roel4990 Jan 22, 2025

Hyobeen-Park Jan 22, 2025

Roel4990 Jan 22, 2025

angryPodo left a comment

Hyobeen-Park left a comment

Hyobeen-Park Jan 22, 2025

Roel4990 Jan 22, 2025

Hyobeen-Park Jan 22, 2025

Roel4990 Jan 22, 2025

Hyobeen-Park left a comment

Hyobeen-Park Jan 22, 2025

Roel4990 Jan 22, 2025

Hyobeen-Park Jan 22, 2025

Roel4990 Jan 22, 2025

Hyobeen-Park left a comment

		@@ -1,11 +1,12 @@
		package com.spoony.spoony.domain.repository

		import com.spoony.spoony.data.dto.base.BaseResponse

[Feat/#120] 게시물 떠먹기 API 연결 #123

[Feat/#120] 게시물 떠먹기 API 연결 #123

Conversation

Roel4990 commented Jan 22, 2025

Related issue 🛠

Work Description ✏️

Screenshot 📸

To Reviewers 📢

chattymin left a comment

Choose a reason for hiding this comment

Hyobeen-Park left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angryPodo left a comment

Choose a reason for hiding this comment

Hyobeen-Park left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hyobeen-Park left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hyobeen-Park left a comment

Choose a reason for hiding this comment